Add progress_bar in mcsolve, ssesolve and dsf_mcsolve #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 93.60% 93.37% -0.24%
==========================================
Files 31 31
Lines 2267 2293 +26
==========================================
+ Hits 2122 2141 +19
- Misses 145 152 +7 ☔ View full report in Codecov by Sentry. |
ytdHuang
approved these changes
Oct 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally, this PR fixes #47.
I added the
progress_barin a type-stable way. I have also changed the compact versions of the standard libs, because we support Julia version v1.10 and above.The, I removed unnecessary calls of
makeVal